Added upgrade step to remove old compaction temp files#6435
Merged
dlmarion merged 4 commits intoJul 10, 2026
Conversation
DomGarguilo
reviewed
Jun 23, 2026
DomGarguilo
reviewed
Jun 23, 2026
dlmarion
commented
Jul 6, 2026
ctubbsii
reviewed
Jul 9, 2026
ctubbsii
reviewed
Jul 11, 2026
| FileStatus[] files = vol.getFileSystem().globStatus(volPattern, | ||
| (p) -> (p.getName().startsWith("" + FilePrefix.FULL_COMPACTION.getPrefix()) | ||
| || p.getName().startsWith("" + FilePrefix.COMPACTION.getPrefix())) | ||
| && p.getName().endsWith(".rf_tmp")); |
Member
There was a problem hiding this comment.
This last check for the suffix is still unnecessary. That's what I was getting at with the suggestion to use the more specific glob pattern.
Member
There was a problem hiding this comment.
After simplifying that, the predicate can be simplified to be:
// before the globStatus() call
char first;
// inside the predicate
p -> (first = p.getName().charAt(0)) == FilePrefix.FULL_COMPACTION.getPrefix() || first == FilePrefix.COMPACTION.getPrefix();(or can do it without the variable by repeating the charAt part)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6285